Move CoreCLR over to the managed wait subsystem #117788
Draft
+7,388
−13,625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
area-System.Threading
runtime-coreclr
|
Tagging subscribers to this area: @mangod9 |
jkoritzinsky
force-pushed
the
coreclr-managed-wait
branch
from
25446d0 to
63dc9af
Compare
This was referenced Jul 22, 2025
Open
jkoritzinsky
force-pushed
the
coreclr-managed-wait
branch
3 times, most recently
from
06de3b2 to
63a1aa6
Compare
This was referenced Jul 31, 2025
src/libraries/System.Private.CoreLib/src/System/Threading/LowLevelLifoSemaphore.Unix.cs
Show resolved
Hide resolved
jkotas
reviewed
Aug 7, 2025
jkoritzinsky
force-pushed
the
coreclr-managed-wait
branch
from
63a1aa6 to
2b610bf
Compare
jkotas
reviewed
Aug 14, 2025
src/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 14, 2025
src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetPageSize.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
force-pushed
the
coreclr-managed-wait
branch
from
4a27a27 to
ac08ce6
Compare
jkotas
reviewed
Aug 14, 2025
jkotas
reviewed
Aug 15, 2025
jkoritzinsky
force-pushed
the
coreclr-managed-wait
branch
from
8838c10 to
9af82b0
Compare
|
@dotnet/samsung Could you please take a look? These changes may be related to riscv64. |
…nents of mutexes from the CoreCLR PAL.
…as already hardened the cases that this makes weird, so we can reliably do it with CoreCLR
…he managed thread object is finalized.
… wait" worker as the only handles it gets on Unix are PAL handles, not wait subsystem handles (and for Windows, we don't need to call back for handles that come through here)
jkoritzinsky
force-pushed
the
coreclr-managed-wait
branch
from
9af82b0 to
b18871c
Compare
…be cleaned up before we run our managed cleanup in CleanupDetachedThreads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the shared managed wait subsystem for CoreCLR's managed code instead of the Win32 PAL
Also, remove the named mutex support from the CoreCLR PAL as nothing uses it now.
TODO: Once #117688 is in, we can remove Mutex support from the Win32 PAL entirely
Unblocks #115685
Depends on #117635